search

freelawproject / reporters-db

A database of court reporters, tests and other experiments
BSD 2-Clause "Simplified" License
93 stars 34 forks source link

CL issue 1888: Fix S.W.2d regex and test for named matching groups #89

Closed mattdahl closed 2 years ago

mattdahl commented 2 years ago

This fix addresses Sentry issue COURTLISTENER-234 discussed in https://github.com/freelawproject/courtlistener/issues/1888.

f9c5e93dfe4fc174eefb5a8ccfc3e70f23de52f3 implements a new test that makes sure that each regex has named <reporter> and <page> matching groups. (I didn't do volume too because at least one of the tax court regexes fail that, and I don't know enough about the tax stuff to know whether they're all expected to have volumes or not.)

6f33550c6b02b55bf293ec1481e4eed24616b1b2 adds a named <reporter> group to the S.W.2d regex that is causing the problems in the Sentry issue. Without this fix the newly-added test fails.

mlissner commented 2 years ago

Python 3.7 is not happy with your walrus operator (see failing tests). Otherwise this looks good.

Want to yank 3.7 and add 3.9 and 3.10?

mlissner commented 2 years ago

Nm, I went ahead and did it. Merged! We'll get this deployed ASAP.