Roll up all the PRs into one : )

freeman-lab / control-panel

embeddable panel of inputs for parameter setting

MIT License

237 stars 17 forks source link

Roll up all the PRs into one : ) #7

Closed rreusser closed 8 years ago

rreusser commented 8 years ago

I know I've overwhelmed you with PRs. This PR rolls up all of the other PRs so that you don't have to worry about the not-100%-trivial merging. I'm glad to make any requested changes or pull out parts if they don't fit, but thought this might save a bit of mental overhead on your part. If this works for you, then can ignore the other PRs. 👍

Thanks!!

freeman-lab commented 8 years ago

This is fantastic @rreusser! I left one note that might be worth looking at, but otherwise think it all looks good to go. Will be really fun to have these!

rreusser commented 8 years ago

Small notes:

Give it a once-over for semistandard formatting
Figure out how to get the tests running. They're minimal but at least rule out syntax errors.
Interval should probably really just accept a mapping function, with maybe a couple presets like 'linear' and 'log'. Relatively minimal changes, but would clean things up a bit.

freeman-lab commented 8 years ago

Ah, are you having trouble with testron? I've had some issues as well, mainly due to electron versioning I think. I'm opening + merging a small PR now that switches to smokestack, which I'm finding works a little more reliably. If you merge that in here you should be able to get the tests running, happy to help if there's trouble.

freeman-lab commented 8 years ago

Oh and re: standard I'm happy merging and then fixing that later.

rreusser commented 8 years ago

Okay, the additional changes made:

The tests weren't actually testing anything except non-exceptions, I think. typof document.querySelector('not-present') === 'object' so that all tests succeeded even if the elements weren't present. I cleaned this up just a bit.
Some components had a UUID attached to the selector, some didn't. Not strictly necessary if no custom styles, but for consistency, I added a UUID across the board.
standard 👍
a couple little style nits
select menu merged into this PR
fixes value overflow issue (values cut off mid-character)

Lots more functionality that could be added, but good to go from my opinion :)

freeman-lab commented 8 years ago

looks fantastic 👍 merging in, thanks for these awesome additions !

freeman-lab commented 8 years ago

fyi just published this as 1.2.0