search

freemint / fvdi

fVDI fork with additional fixes and drivers.
https://fvdi.sourceforge.io
7 stars 6 forks source link

Pass fix31 (not short) height to external vst_height() #37

Closed chrisridd closed 2 years ago

chrisridd commented 2 years ago

This should fix your code @mfro0 ! Apologies for missing this case.

mfro0 commented 2 years ago

way better - many thanks!

mfro0 commented 2 years ago

there is still something not quite right.

Running on hatari with the bitplane driver, TT emulation (640x480*4 Planes), the AES for some reason use the small system font instead of the 16x8 font normally used:

grab0002 (note menu bar and window title)

chrisridd commented 2 years ago

I did notice the 8x8 font in the screenshot, but wasn't sure if that was expected. I'll put a hatari installation together to reproduce this.

mfro0 commented 2 years ago

I'm wondering if it's caused by the bitplane.sys driver that uses more functionality from the ROM VDI than the other drivers.

Maybe the ROM driver sees the changed structure field value somehow?

chrisridd commented 2 years ago

That's an interesting idea. The contents of the Fontheader size/dummy field are still flipped, so if something's still assuming those bytes are the size they should be getting the right data. Similarly, insert_font() just mechanically changes from checking size to extra.size so that should be OK too.

The emutos aes sources didn't give me any insights as to what it was calling to setup the font. Everything seems to rely on defaults :-(

I'm having trouble getting a hatari setup (using hatari-2.3.1 ) that boots fvdi successfully... do you have any tips or sample configs?

mfro0 commented 2 years ago

fvdi_test.tar.gz

This is my test directory. After unpacking, just start hatari from that directory with hatari -c tt.cfg. You'll need to adapt the symbolic links to fvdi_gnu.prg (inside the auto folder) and bitplane.sys (in the gemsys folder) and the paths in the .cfg file (EmuTOS image and others) to your dev setup.

Then it should 'just work ™'. Hopefully.f

mfro0 commented 2 years ago

any progress on this? Might be better to reverse previous changes?

chrisridd commented 2 years ago

Sorry, I've been out of action for a bit. I have some ideas and will start investigating this weekend while I'm still (grr) isolating.

mfro0 commented 2 years ago

Don't worry, sometimes life gets in the way. Wish you a speedy recovery.

mfro0 commented 1 year ago

I have now reverted both fix31 commits as others have problems with wrong font heights in the desktop as well. Will be revisited if you (or somebody) can come up with a solution.

chrisridd commented 1 year ago

Understood, and it was the right call to make. Clearly the change was too ambitious :-(