search

freemint / fvdi

fVDI fork with additional fixes and drivers.
https://fvdi.sourceforge.io
7 stars 6 forks source link

Remove buildit.sh #42

Closed cdpjenkins closed 2 years ago

cdpjenkins commented 2 years ago

In response to #41.

cdpjenkins commented 2 years ago

I added a commit to update the README with instructions on building FDVI using the Makefile directly rather than using the now-deleted buildit.sh. Interested in feedback on whether what it says now it correct.

cdpjenkins commented 2 years ago

I realised I raised this PR a few weeks ago and it's still open. Is it possible to merge it as-is? Or are there any changes I could make?

(It doesn't do anything, other than remove the buildit.sh script, but I feel like there's some value in removing that script given that it isn't needed and has some problems when run on a box that does not have PortAsm.)

mfro0 commented 2 years ago

I realised I raised this PR a few weeks ago and it's still open. Is it possible to merge it as-is? Or are there any changes I could make?

No, it's just fine, as discussed previously. Was away from my computers for a few weeks and forgot everything regarding fVDI ;)

Thanks for the heads-up.