search

freemint / tos.hyp

The tos.hyp tries to document all functions from TOS. It also has information about MagiC, N.AES, MyAES, Geneva, XaAES, oAESis and some emulators.
https://freemint.github.io/tos.hyp
GNU General Public License v2.0
13 stars 11 forks source link

Resolves #112 : note on VgetRGB/VsetRGB #113

Closed sporniket closed 2 years ago

mikrosk commented 2 years ago

I think a better (more detailed) description would be helpful here. Although I am aware of this behaviour, I've been lazy to verify my hypothesis: is it because VgetRgb(256) reads 16 initialised colours + 240 random colours and then does the same with VsetRgb(256) but due to bank mirroring only the last 16 (garbage) colours are applied?

sporniket commented 2 years ago

I have created this PR to not let the info be lost after the poster on atari-forum did report this find. I have no Falcon to detail the actual behavior.

I believe the warning is helpfull to people not being aware of that, even if it does not details what actually happen. It can always be polished later.

sporniket commented 2 years ago

@mikrosk if you can check and details the actual behaviour, I will happily update this PR :)

th-otto commented 2 years ago

I would have thought that it is rather obvious that you should not try using invalid color indices. Of course that does not mean that a clarification is not helpful. But i guess that also applies to lot of other places.

th-otto commented 2 years ago

BTW, there is a typo in your 2nd patch (b! instead of !b). See also error messages in https://github.com/freemint/tos.hyp/actions/runs/3194724405/jobs/5218767278

sporniket commented 2 years ago

@th-otto should be good now