freenas / iocage-ix-plugins

Official iXSystems iocage plugins for FreeNAS and TrueOS
175 stars 109 forks source link

Add zrepl plugin #226

Closed johnramsden closed 4 years ago

johnramsden commented 4 years ago

Summary

zrepl is zfs replication software.

Tests

Tested the plug-in via:

iocage fetch -P /tmp/zrepl.json --name zrepl-test jail_zfs_dataset="zrepl"

Questions

I wasn't sure who should be labelled as the maintainer, myself or ixsystems. It also does not have a icon, so I left it out.

Regarding setup tasks. I couldn't find a way to run commands on the main system, I don't know if this is possible. Is there a way to have a user specify a dataset they want delegated, and optionally created? For now I have left a message in the post_install.sh stating:

A ZFS dataset must be delegated into the zrepl jail. Create a dataset on the host if one was not delegated during jail creation, stop the plugin jail, and set the following iocage property:

jail_zfs_dataset=<delegated dataset>

The "\<delegated dataset>" should not contain the pool name.

kmoore134 commented 4 years ago

Thanks John! Please submit this to our community repo here instead:

https://github.com/ix-plugin-hub/iocage-plugin-index/

kmoore134 commented 4 years ago

You can also come up with a generic icon for it, since there isn't anything specifically.