freenas / iocage-ix-plugins

Official iXSystems iocage plugins for FreeNAS and TrueOS
175 stars 109 forks source link

Dnsmasq logo need alpha channel? #268

Closed justinclift closed 3 years ago

justinclift commented 3 years ago

Just noticed Dnsmasq in the list of Community plugins for FreeNAS. Cool. :smile:

The logo though seems a bit off for dark themed UI's, as it has a hard coded white background. Guessing it's just a missing alpha channel, though I haven't yet looked properly.

That being said, would using an SVG be acceptable instead of a PNG?

I think the original icon created for Dnsmasq (SVG format) is still kicking around in my archives somewhere. Can try digging that up if it'd be useful.

CC @timsavage for awareness. :smile:

kmoore134 commented 3 years ago

I think an SVG would work, however we've only done PNG's thus far, so if something goes bad we may need to replace it with png again with the proper transparency.

justinclift commented 3 years ago

No worries, sounds like a workable approach.

Looking through my archives, I'm not finding the SVG I was thinking of. So I've emailed Simon (Dnsmasq maintainer), to see if he still has the original file. Hopefully that'll work out. :smile:

justinclift commented 3 years ago

Closing this, as the PR to switch to an SVG file (https://github.com/ix-plugin-hub/iocage-plugin-index/pull/149) has been merged. :smile: