search

freenas / iocage-plugin-emby

Artifact file(s) for Emby iocage plugin
2 stars 6 forks source link

Remove Custom Overlay #7

Closed LukePulverenti closed 2 years ago

LukePulverenti commented 2 years ago

And use the one embedded in the Emby package. Among other things, this will allow the dotnet runtime to be used instead of the mono runtime.

Baenwort commented 2 years ago

This works to fix the problem I'm having with building a dev branch plug-in. With this change my https://github.com/Baenwort/iocage-plugin-index/blob/master/emby.json plug in works!

LukePulverenti commented 2 years ago

This works to fix the problem I'm having with building a dev branch plug-in. With this change my https://github.com/Baenwort/iocage-plugin-index/blob/master/emby.json plug in works!

Yea if we can get this merged and then updated in TrueNAS this is going to help with a lot of the problems users are having.

Baenwort commented 2 years ago

It looks like this https://github.com/freenas/iocage-plugin-emby/issues/9#issuecomment-1215276624 is also trying to fix the same issue. It seems to be more active so perhaps one of the two will get merged and we can all be happy!

jasker5183 commented 2 years ago

Closed my issue and PR as I inadvertently filed a duplicate. Is there any way we can expedite this or is it advantageous to roll broken plugins?