search

freenas / iocage-plugin-emby

Artifact file(s) for Emby iocage plugin
2 stars 6 forks source link

13.1-RELEASE #9

Closed jasker5183 closed 1 year ago

jasker5183 commented 1 year ago

I'm trying to get all the plugins updated for the 13.1-RELEASE here and since Emby has switched from Mono to .NET the emby-server service file in your artifact repo no longer works. Any chance you could replace it with this?

emby-server.txt

sonicaj commented 1 year ago

@jasker5183 can you please make a PR and we can review ? Thanks!

jasker5183 commented 1 year ago

Filed PR three days ago. The only question I have is should the overlay folder be updated to include the new init script? Or should it be removed so the new .NET init can be installed automatically?

sonicaj commented 1 year ago

@jasker5183 if something can automatically be pulled in by installing a package for example, we should not be defining the same file ourselves unless we want to override of course.

Please let me know if that clarifies your question. Thanks!

jasker5183 commented 1 year ago

Deleted the overlay directory and tested again working fine.

Baenwort commented 1 year ago

@sonicaj This is also fixed in: https://github.com/freenas/iocage-plugin-emby/pull/7 which is a pull request by the developers of Emby to try and address this problem that has been lingering for a while.

jasker5183 commented 1 year ago

If that pull request was filed in July what is the hold up? I should probably close this then?

jasker5183 commented 1 year ago

Closing this as it's a duplicate.