freenode / Sigyn

A Limnoria plugin to fight abuse on IRC networks
Other
46 stars 31 forks source link

in kline(), `mask` is already *@ip but `prefix` is still @gateway/ #49

Closed jesopo closed 4 years ago

jesopo commented 4 years ago

from local testing, it would appear Sigyn is currently attempting to WHOWAS people with @gateway/ cloaks even though, I believe, WHOWAS against i-line spoofed users does not return RPL_WHOISACTUALLY, thus these people get stuck waiting for a WHOWAS to trigger a k-line.

I think the reason for this is mask in kline() has already had the prefixToMask() treatment, thus checking if there's @gateway/ in mask won't work, because it's already *@ip, so instead use prefix as that's the unmodified user n!u@h.