freenode / ircd-seven

freenode's IRC server daemon
Other
200 stars 48 forks source link

add @ prefix to op-moderated (+z) messages #31

Closed mquin closed 6 years ago

mquin commented 7 years ago

This change is a proposed solution to #30. It modifies op-moderated (+z) messages to distinguish them from regular channel traffic.

This is done by altering sendto_channel_opmod() to add an @ prefix, as with @#channel messages to all operators.

mquin commented 7 years ago

@robbyoconnor No - the @ needs to be prepended to the channel name, as is the case when '/msg @#channel' is used to send a message to all operators.

Inserting a space would result in an inconsistency in the number of arguments to PRIVMSG and likely be confusing to clients.

robbyoconnor commented 7 years ago

Ahh! okay!

bigpresh commented 7 years ago

Do all clients handle receiving messages targetted to @#channel instead of #channel sanely? If so, this looks rather sensible to me - it would be very nice to tell at a glance "I'm seeing this because of +z but normal users aren't, so let them rant into the ether if they wish" :)

a-raccoon commented 6 years ago

I would also like to see how clients respond to a - prefix to the channel name, instead of recycling @. This may or may not require an addition to 005 PREFIX=(ov)@+, ie PREFIX=(ovz)@+-

ilbelkyr commented 6 years ago

I've added a config option for this; the main change has been tested but I haven't made sure I didn't inadvertently break something by adding the config option, so I'm not merging this yet.