freenowtech / wave

Design System of FREE NOW
https://wave.free-now.com
Apache License 2.0
64 stars 22 forks source link

Accordion shows unwanted dividers when expanded #186

Closed martimalek closed 1 month ago

martimalek commented 2 years ago

Relevant code

There is a <HorizontalDividerTop /> in line 39 of Accordion.tsx and a <HorizontalDividerBottom /> in line 63 of Accordion.tsx

What was expected to happen?

The two dividers should not render when the default component is expanded

Reproduction

You can see the current behaviour in Wave's accordion page

Screenshot 2021-10-25 at 14 08 41

Link to Figma

lloydaf commented 2 years ago

@martimalek What two dividers should not be expected to be rendered here (I see three dividers)? The one in the middle should be there?

martimalek commented 2 years ago

@lloydaf Yes, the one in the middle should be there, the other two should not

arturmiglio commented 1 month ago

Moved to internal backlog.