freenowtech / wave

Design System of FREE NOW
https://wave.free-now.com
Apache License 2.0
64 stars 22 forks source link

Fix datepicker elevation, props and bottom-lined input ref #425

Closed martimalek closed 4 months ago

martimalek commented 4 months ago

What

Media

Before (Datepicker underneath Modal)

image

After (Datepicker on top of Modal)

image

Why

To offer a consistent experience on the Datepicker and Input components

How

Closes #421

nlopin commented 4 months ago

I'd try attaching the datepicker popup to the modal, not to the body. In that case, the elevation of the modal will be used and we can rely on it. I'm not confident it will work, but I don't see the reason why it shouldn't

martimalek commented 4 months ago

I'd try attaching the datepicker popup to the modal, not to the body. In that case, the elevation of the modal will be used and we can rely on it. I'm not confident it will work, but I don't see the reason why it shouldn't

@nlopin how can we know to which element to attach it to? Do you mean having a new prop (e.g. portalContainer)?

nlopin commented 4 months ago

I'd try attaching the datepicker popup to the modal, not to the body. In that case, the elevation of the modal will be used and we can rely on it. I'm not confident it will work, but I don't see the reason why it shouldn't

@nlopin how can we know to which element to attach it to? Do you mean having a new prop (e.g. portalContainer)?

yep, that's the issue. Let's merge this solution and see whether the z-index war will start or not 😂

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: