search

freeotp / freeotp-android

Apache License 2.0
1.37k stars 288 forks source link

Update Firefox logo #346

Open WebSnke opened 10 months ago

WebSnke commented 10 months ago

The Firefox logo that is used in FreeOTP is still the old one from 2017. I suggest updating it to the modern Firefox logo.

albeec13 commented 9 months ago

Technically the proper logo to use would be this one, since it's a Firefox Account, not a browser: image

WebSnke commented 9 months ago

Technically the proper logo to use would be this one, since it's a Firefox Account, not a browser: image

Yeah, but I think we should use the one for the Browser because it looks like the Crunchyroll logo once you only show it in one color...

image

albeec13 commented 9 months ago

I can use the browser logo instead if @justin-stephenson is ok with that. The existing one was using that anyway.

Related browser/fox logo: https://fontawesome.com/icons/firefox-browser?f=brands&s=solid Firefox account logo: https://fontawesome.com/icons/firefox?f=brands&s=solid

justin-stephenson commented 9 months ago

I can use the browser logo instead if @justin-stephenson is ok with that. The existing one was using that anyway.

Related browser/fox logo: https://fontawesome.com/icons/firefox-browser?f=brands&s=solid Firefox account logo: https://fontawesome.com/icons/firefox?f=brands&s=solid

I'm fine with either.

WebSnke commented 7 months ago

So "Firefox Account" has been renamed to "Mozilla Account". I think we should therefore also change its name in FreeOTP and update to the logo @albeec13 suggested.

justin-stephenson commented 7 months ago

So "Firefox Account" has been renamed to "Mozilla Account". I think we should therefore also change its name in FreeOTP and update to the logo @albeec13 suggested.

Change the name where? The FontAwesome icons are associated with their name string stored in https://github.com/freeotp/freeotp-android/tree/master/mobile/src/main/res/drawable

You can submit a PR to duplicate/copy this file fa_firefox.xml as needed.

WebSnke commented 7 months ago

So "Firefox Account" has been renamed to "Mozilla Account". I think we should therefore also change its name in FreeOTP and update to the logo @albeec13 suggested.

Change the name where? The FontAwesome icons are associated with their name string stored in https://github.com/freeotp/freeotp-android/tree/master/mobile/src/main/res/drawable

You can submit a PR to duplicate/copy this file fa_firefox.xml as needed.

I meant the name that appears next to the token generator in the app.

Screenshot 2023-11-28 at 10-20-36 FreeOTP - Wikipedia