Closed joggee-fr closed 9 months ago
This is my proposal to add a French translation to FreeOTP. I sometimes had to not stick to the English base sentences to make it clearer in French.
Thank you for the PR.
BTW, is there difference between "issuer" and "provider"? I decided to stay with "fournisseur" in French which is closer to "provider". A possible translation for "issuer" could be "émetteur".
Issuer
refers to this specific OTP URI field https://github.com/google/google-authenticator/wiki/Key-Uri-Format#issuer
which essentially means the same thing as the OTP provider. The issuer parameter is a string value indicating the provider or service this account is associated with
If no more changes are needed I will go ahead and merge this, just let me know.
@justin-stephenson, thanks for the detail. Let me triple-check my proposal in this case. Would be great if another French-speaking contributor could give it a look. Pinging @futal from PR #174 for example.
Hello
I've just translated the file in Corsican but I have good knowledges in French ;-)
In my opinion, there is no problem to translate issuer by « Fournisseur ».
I noticed a couple of typos on lines 114 and 118 and I added a comment on your file.
Best regards, Patriccollu.
I've just translated the file in Corsican but I have good knowledges in French ;-)
Thanks for your review @Patriccollu. Rebased, triple-checked and fixed the typos.
@justin-stephenson, my proposal is now ready to be merged if you are OK with it.
Hi. Sorry for the late reply. I confirmed the changes suggested by @Patriccollu. Here are some more typos I found in mobile/src/main/res/values-fr/strings.xml:
Thanks @futal.
As I understant it, lines 120 and 121 are content description for images (just like alt property for HTML tag img for example). I don't think they are really displayed but could be nice for accessibility, screen reader and stuff like this.
Then lines 120 and 121 are fine for alt properties (it is not clear out of context as there are no uppercase after "Image" but they become clear as alt tags which are usually pronounced with a different voice and the upper case does not matter there).
Thanks again for yours reviews @Patriccollu and @futal.
This is my proposal to add a French translation to FreeOTP. I sometimes had to not stick to the English base sentences to make it clearer in French.
BTW, is there difference between "issuer" and "provider"? I decided to stay with "fournisseur" in French which is closer to "provider". A possible translation for "issuer" could be "émetteur".