search

freeotp / freeotp-android

Apache License 2.0
1.37k stars 290 forks source link

Several minor changes for UI and extra stuff #398

Closed joggee-fr closed 2 weeks ago

joggee-fr commented 3 weeks ago

Hi, I would like to propose some modifications to the application.

  1. Replacement hardcoded welcome string displayed on the welcome fragment with a translatable one added to XML string resource file. By the way, add a French translation.
  2. Simply use tools:listitem in main activity RecyclerView to preview the screen in Android Studio with item layout.
  3. Add margins / padding to manual add activity layout. I have also moved away the Toolbar from ScrollView to follow the behavior from main activity layout. Speaking of Toolbars, anybody know why they are nested in AppBarLayouts? I understand it could be interesting to add scrolling gestures but I can't see where such a feature is used in the FreeOTP application.
  4. Nest password activity layout in a ScrollView. It should fix issue #349.
  5. Add a long click listener on item to select it, the same way clicking on image does. It addresses part of issue #278.
  6. Fix hyperlink not well displayed in backup fragment.
  7. Minor stuff.

Let me know if you want me to split these commits in several PRs instead. Thanks.

justin-stephenson commented 3 weeks ago

Thank you for the PR @joggee-fr - Please allow me some time to test the changes and UI flows.

justin-stephenson commented 2 weeks ago

@joggee-fr Changes tested locally and look good to me, thank you.