search

freeotp / freeotp-ios

Apache License 2.0
686 stars 173 forks source link

Please use grey or customizable colour instead of strange green that is clashing with custom icon colours. #154

Closed OddHouseGames closed 4 years ago

OddHouseGames commented 4 years ago

The green behind all the custom icons clashes with all icon colours.

What is the signifigance of the thick green border? If this represents something, is there no better way to use it rather than outline all the custom icons?

justin-stephenson commented 4 years ago

Thanks for the feedback @Githubuxer - this was an unintended side effect of the new token icon feature, we will make sure to fix this problem for migrated custom icon tokens.

OddHouseGames commented 4 years ago

Got it, so is there a way to remove/edit the token icons now or does it work differently.

justin-stephenson commented 4 years ago

You can re-add any existing migrated tokens to take advantage of the new token icon feature.

We can also create a manual mapping from an Issuer name to a Font Awesome icon, this requires that the brand icon that you want to use is already in Font Awesome. You can submit a Pull Request for this Issuer -> Icon mapping by adding to the collection here, it will be hardcoded into FreeOTP.

https://github.com/freeotp/freeotp-ios/blob/5b35edb8db43d7c01fa88ff74ac1a0f8ee584690/FreeOTP/TokenIcon.swift#L303

OddHouseGames commented 4 years ago

Got it, how do you edit icons now? I can’t seem to figure it out, unless this is an issue with migrated icons.

justin-stephenson commented 4 years ago

The editing functionality after a token is stored(like with migrated tokens/icons) was removed in v2.0.

OddHouseGames commented 4 years ago

Got it, so only way is to delete token and re-add?

Sent from ProtonMail Mobile

On Tue, Jun 2, 2020 at 4:26 PM, Justin Stephenson notifications@github.com wrote:

The editing functionality after a token is stored(like with migrated tokens/icons) was removed in v2.0.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

justin-stephenson commented 4 years ago

Yes, that's correct @Githubuxer

justin-stephenson commented 4 years ago

Fixed in v2.1