freeotp / freeotp-ios

Apache License 2.0
687 stars 174 forks source link

Add search feature #202

Closed daviesalex closed 3 years ago

daviesalex commented 4 years ago

When having a large number of OTP sites, searching manually by Icon is annoying (especially when having multiple applications with the same Icon).

A quick ability to search (magnifying glass in the menu bar) would really help out here. As you type letters, the list of icons shown should change to only show the list that match what you entered.

mul1sh commented 4 years ago

@daviesalex Will implement the search for ios in the next few days then 🙂

daviesalex commented 4 years ago

Thanks @mul1sh ! I've asked the folk at bountysource.com to flip the bounty to point to this issue, since its pointless in the other issue as you pointed out.

Update: this is done. https://www.bountysource.com/issues/94341512-add-search-feature sponsors this issue.

mul1sh commented 4 years ago

Awesome thanks @daviesalex will keep you updated on my progress here 🙂

alphashuro commented 4 years ago

@daviesalex I've submitted a PR for this

mul1sh commented 4 years ago

Ok i've implemented the search functionality in the navigation bar as required @daviesalex. I added the search bar programatically as opposed to using the storyboard to avoid the issues noted in the comments here and also to make sure the search is always shown regardless of how large the token list is.

So on clicking the search icon, the app will display the search bar and filter the codes as you search as shown here.

daviesalex commented 4 years ago

Great! @mul1sh that looks to meet our requirements perfectly. ( @alphashuro without a screenshot demo i'm less sure what your PR does exactly, but hopefully the project maintainer can review both and merge one of them! )

alphashuro commented 4 years ago

Thanks @daviesalex I'll record a screenshot and add it!

mul1sh commented 4 years ago

@daviesalex thanks glad you like it 👍, I've updated my PR with the UI tests for search functionality, so now its ready for review 🙂