search

freeotp / freeotp-ios

Apache License 2.0
686 stars 173 forks source link

#186 manual secret entry (2) #279

Closed igor2890 closed 2 years ago

justin-stephenson commented 2 years ago

Hi,

Thank you very much for the pull request @igor2890 , I appreciate your willingness to contribute to the project.

I have not tested the functionality yet, but first let me add some comments about the UI.

I am recently working on adding manual secret entry to FreeOTP Android, for uniformity across platforms could you please match this UI as closely as possible ? Digits can remain 6 through 9 unlike in the screenshot.

android-manual-add

Please also change "Enter OTP" to "Manual Add".

Instead of "Some problems", please use the alert dialog box messages as below:

    Token is invalid!

    The token you are attempting to add is invalid. Please check that each field is valid following the OTP Key Uri Format.

You may also want to add a 'Lock' checkbox which can be enabled. It should warn that locked tokens will not be included in backups.

It would be great to add a UITest for this also.

It looks like the git commit history needs to be cleaned up also.

igor2890 commented 2 years ago

Hello @justin-stephenson ! Thanks for your feedback. Of course, I will consider all your comments. About the "Lock" checkbox - I used an already existing screen URILockViewController for this purpose.

justin-stephenson commented 2 years ago

Hello @justin-stephenson ! Thanks for your feedback. Of course, I will consider all your comments. About the "Lock" checkbox - I used an already existing screen URILockViewController for this purpose.

Okay great, that works also.

If you have any questions just let me know.

justin-stephenson commented 2 years ago

Replaced by https://github.com/freeotp/freeotp-ios/pull/281