Fixed search bar transition

freeotp / freeotp-ios

Apache License 2.0

686 stars 173 forks source link

Fixed search bar transition #285

Closed igor2890 closed 2 years ago

igor2890 commented 2 years ago

- Redesigned search bar with default UISearchController to meet HIG requirements and simplify code
- Fixed missing cancel button on iPad
- Removed account property (UUID type) from token searching filter

Fixes #229

Hidden:

Unhidden:

Active:

igor2890 commented 2 years ago

Hi @justin-stephenson ! Are there any suggestions for this pull request? I want to try to implement a UICollectionView List (issue #268) and would like to do so given this pull request.

justin-stephenson commented 2 years ago

Hello @igor2890 - This PR is working well, but would like to avoid moving around the top bar icons (scan, manual add token). Thanks for cleaning up the code here.

Please use a separate PR for the issue #268.

igor2890 commented 2 years ago

@justin-stephenson - OK, I got the buttons back

justin-stephenson commented 2 years ago

Changes LGTM, thanks!