search

freeotp / freeotp-ios

Apache License 2.0
686 stars 173 forks source link

iOS version is not pulling the tokenissuer field from PrivacyIDEA #308

Closed mgryka closed 1 year ago

mgryka commented 1 year ago

PrivacyIDEA settings:

Behavior on Android freeOTP: User scans QR code. New token appears:

  • companyname
  • user@companyname.example

Behavior on iOS freeOTP: User scans QR code. User asked for input for token issuer. User asked to choose icon. New token appears:

  • user input
  • user@companyname.example

Am I misconfiguring something? The Android app is as expected.

mgryka commented 1 year ago

The content of the QR: otpauth://totp/user@companyname.exampleTOTPXXXXXXXX?secret=XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX&period=30&digits=6&issuer=companyname

justin-stephenson commented 1 year ago

Hi,

The token label should also contain the account name, in the format issuer:account, see https://freeotp.github.io/qrcode.html for example.

That said we could maybe handle this better by checking for the issuer parameter, instead of only relying on the label.

mgryka commented 1 year ago

Thanks for the reply!

I'll root around in PrivacyIDEA but from the looks of it there isn't much I can do to change the way this information is conveyed in the QR code.

It isn't a dealbreaker by any means, I just want to make this as easy as possible on my end users (for my sake! haha).

mgryka commented 1 year ago

After using the tool in the link you provided and digging a little bit deeper into the PrivacyIDEA settings, it looks like I was able to hardcode it as part of the label. I tested on iOS and it works as expected!

I really appreciate you taking the time to help me work through this @justin-stephenson Thanks again!