search

freeotp / freeotp-ios

Apache License 2.0
686 stars 173 forks source link

Update Fedora logo with new logo and change background colour #309

Closed jessicachitas closed 1 year ago

jessicachitas commented 1 year ago

Hi there!

My name is Jess Chitas and I am from the Fedora Design team.

I noticed that the logo that you have for the Fedora OTP is out of date and we would like if it was changed to the new logo. Attached is an SVG and PNG of the logo that we would like you to use.

Another issue as well is the background colour that is not within our brand guidelines. The colour we would like to change it to would be #51a2da which is the New Fedora Blue.

Thank you!

fedora-logo-replacement-for-otp fedora-logo-replacement-for-otp

mairin commented 1 year ago

commenting for follow

justin-stephenson commented 1 year ago

@jessicachitas Thank you, I will make sure to update our logo and background color. I suspect the same should be done for https://github.com/freeotp/freeotp-android

jessicachitas commented 1 year ago

Hi @justin-stephenson , yes please! Will I file a ticket in there as well?

justin-stephenson commented 1 year ago

Hi @justin-stephenson , yes please! Will I file a ticket in there as well?

Yes please.

Neustradamus commented 1 year ago

@justin-stephenson: For security, iOS app need an update too, there is not only Android. There are other tickets too...

justin-stephenson commented 1 year ago

Android PR submitted here https://github.com/freeotp/freeotp-android/pull/366

I will submit the iOS PR soon.

Neustradamus commented 1 year ago

@justin-stephenson: Nice!

Can you help to solve other iOS problems too?

justin-stephenson commented 1 year ago

It appears the FontAwesome library we are using in iOS has not been updated in some time (https://github.com/thii/FontAwesome.swift/issues/281) so we may need to stop depending on this external library.

justin-stephenson commented 1 year ago

It appears the FontAwesome library we are using in iOS has not been updated in some time (thii/FontAwesome.swift#281) so we may need to stop depending on this external library.

Perhaps we can use https://github.com/LiveUI/Awesome - if not we could add the FontAwesome icon kit into the iOS project but then we have to manually update it each time there is a new FontAwesome icon set.

justin-stephenson commented 1 year ago

This will be fixed when https://github.com/freeotp/freeotp-ios/pull/329 is included in a new release.

Neustradamus commented 1 year ago

@justin-stephenson: Good job!

Can you look other important tickets?

Thanks in advance.