search

freeotp / freeotp-ios

Apache License 2.0
686 stars 173 forks source link

Serious problem with invalid image-parameter #351

Closed pk1234 closed 6 months ago

pk1234 commented 6 months ago

If the otpauth-URL contains an invalid image-parameter, for example: otpauth://totp/ACME:Jon%20Doe?secret=3GPF4SQT5YMF52AX76RGL3TQP7YSNOFY&image=none then FreeOTP will crash when such a qr-code is scanned.

This seems harmless, but after that has happened, FreeOTP will crash whenever it's started again, so you loose all of your tokens.

And even worse: FreeOTP will even crash after you delete it from your phone and did a fresh reinstall from AppStore. So the invalid URL is cached somewhere even after the app was deleted - strange!

Any ideas how to recover this situation?

Peter

grafik

Do not scan the above qr-code with FreeOTP - you will not be able to use FreeOTP ever again

justin-stephenson commented 6 months ago

Thank you for reporting this, it is a serious issue. I will investigate a fix.

Duplicate of https://github.com/freeotp/freeotp-ios/issues/340

justin-stephenson commented 6 months ago

https://github.com/freeotp/freeotp-ios/pull/352 merged, I'll work next on building and pushing a new FreeOTP release to the app store.

pk1234 commented 6 months ago

Thanks very much Peter

justin-stephenson commented 6 months ago

@pk1234 Please check if updating to the new release 2.3.5 helps for you