search

freeotp / freeotp.github.io

177 stars 87 forks source link

Rename tokens #42

Closed wehurlbert closed 1 year ago

wehurlbert commented 3 years ago

It appears that the ability to rename tokens, and select images, has disappeared from the iOS app. This greatly reduces the utility of the app. What's going on?

Neustradamus commented 2 years ago

@npmccallum, @justin-stephenson, @freeotp team: I have updated the app and I can not rename tokens...

Can you add again the feature?

jekuno commented 1 year ago

I'd also love to see that feature. I use two services with 2FA which changed their name inbetween and it would help to have the correct names for quickly finding the corect tokens.

conloos commented 1 year ago

+1

justin-stephenson commented 1 year ago

If you touch the token icon, a pencil icon should appear in the above menu - press this pencil icon to edit the token label.

jekuno commented 1 year ago

Doesn't work for me. Touching the token icon (or the text next to the icon) in the iOS app simply generates a new token.

justin-stephenson commented 1 year ago

Doesn't work for me. Touching the token icon (or the text next to the icon) in the iOS app simply generates a new token.

Could you please provide a screenshot, or video of this?

jekuno commented 1 year ago

The video doesn't show the tap unfortunately, but that's how it looks like, when I tap on the grey symbol on the left side:

https://user-images.githubusercontent.com/10961144/220406728-b697c97e-1efe-4c6e-8d56-8b6cd9088099.mov

Neustradamus commented 1 year ago

I confirm a new time the problem (we can not rename a token), and there is no possibility to change the icon too.

justin-stephenson commented 1 year ago

Sorry, I assumed we were talking about Android. Unfortunately iOS does not support changing the token name currently, I am open to adding this functionality however. PRs are welcome.

Neustradamus commented 1 year ago

@justin-stephenson: It has been solved?

Neustradamus commented 1 year ago

@justin-stephenson: Can you generate the new release with this fix?

Thanks in advance!

justin-stephenson commented 1 year ago

This should be filed against https://github.com/freeotp/freeotp-ios - I believe there is already an existing issue open for this in that repo.

Neustradamus commented 1 year ago

@justin-stephenson: It is better to transfer all iOS issues in the good repo, and Android issues in the good repo too!