freeotp / freeotp.github.io

177 stars 84 forks source link

Update to new design #78

Closed WebSnke closed 10 months ago

WebSnke commented 11 months ago

This PR updates the design of the FreeOTP website.

Screenshot: image

WebSnke commented 11 months ago

@justin-stephenson Could you maybe take a look at this PR?

justin-stephenson commented 11 months ago

@WebSnke Thank you for the PR, can we add links to the Google Play and iOS App store ? What will be the download.html file that is currently empty?

image

I see what looks like a border/margin issues here (I am using firefox).

Please also link to the Privacy Policy https://freeotp.github.io/privacy.html

Otherwise it looks great to me.

WebSnke commented 11 months ago

@WebSnke Thank you for the PR, can we add links to the Google Play and iOS App store ? What will be the download.html file that is currently empty?

image

I see what looks like a border/margin issues here (I am using firefox).

Please also link to the Privacy Policy freeotp.github.io/privacy.html

Otherwise it looks great to me.

I already linked to the privacy policy in the footer. What do you mean by "border/margin issues"?

WebSnke commented 11 months ago

@WebSnke Thank you for the PR, can we add links to the Google Play and iOS App store ? What will be the download.html file that is currently empty?

image

I see what looks like a border/margin issues here (I am using firefox).

Please also link to the Privacy Policy freeotp.github.io/privacy.html

Otherwise it looks great to me.

The download.html is supposed to contain the links for downloading FreeOTP. Do you think I should just add the banners on the index.html instead?

Update: I just tried to create a embeded banner for the Google Play Store and the App Store but it turns out that the Google Play Store uses a default padding in the image itself. This sucks because the banner would have different heights.

WebSnke commented 10 months ago

I would like to start with a new PR for updating the design as I think that this commit history got a bit messy...