search

freeplane / docs

120 stars 77 forks source link

fix theme switch symbol position #45

Closed dpolivaev closed 2 years ago

macmarrum commented 2 years ago

@dpolivaev I propose a different approach, i.e. to change z-order and put the sun/crescent button above the github corner. It looks better, in my opinion: https://macmarrum.github.io/freeplane-docs/

dpolivaev commented 2 years ago

I have not got z-order to work. But I also do not think that the buttons should overlap. Your solution depending on the window size does not look right, see attached screenshot. Selection_119

macmarrum commented 2 years ago

The overlap is intentional. I like it better when the buttons overlap as compared to a big gap between the sun-crescent button and the github corner.

I believe the sun-crescent button should be located out of the way, barely noticeable. Otherwise we can put it on the left, just like when the page is sized below 768 px.

dpolivaev commented 2 years ago

I am afraid for me the overlap looks quite wrong. You like it, and I hate it because the elements do not belong together.

Do you have some other placement idea for the button which could please the both of us?

macmarrum commented 2 years ago

All clear.

I've tried other options and concluded that the location proposed by you is my choice #2. Therefore it's fine with me.

dpolivaev commented 2 years ago

Many thanks