search

freeplane / docs

120 stars 77 forks source link

add new-generation workflow #88

Closed macmarrum closed 2 years ago

macmarrum commented 2 years ago

It looks to me that GitHub changed the way GitHub Pages are deployed.

The action JamesIves/github-pages-deploy-action relies on the mechanism where Pages are auto-deployed from an orphan branch gh-pages. But in my case, the action fails to push files to GitHub Pages. I noticed that the files generated by that action can be pushed by the built-in mechanism Deploy from a branch, from gh-pages.

In GitHub docs I can see a different mechanism, i.e. built-in actions to upload an artefact and to deploy it to Pages: https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow

mdbook-github-pages.yml defines a (manually-triggered) workflow, which uses this mechanism.

To use it as the main (automated) GitHub-Pages deployment mechanism

  1. mdbook.yml needs to be removed or the workflow trigger disabled
  2. In mdbook-github-pages.yml, the workflow trigger needs to be enabled (on: push ...)
  3. In Settings, Deploy from a branch needs to be switched to GitHub Actions

@dpolivaev what's your view on this, please?

dpolivaev commented 2 years ago

But in my case, the action fails to push files to GitHub Pages

Why?

You have not given me a status sufficient to see your repo and gh-pages settings, and so I do not know what is different in your case.

I can give you all rights on the freeplane-docs repository if you promise me to get it to work. Then I could concentrate on coding. Please let me know how you see it.

macmarrum commented 2 years ago

You have not given me a status sufficient to see your repo and gh-pages settings, and so I do not know what is different in your case.

I don't know how to give other permissions. I think that on personal accounts there is only the Collaborator access right.

I can give you all rights on the freeplane-docs repository if you promise me to get it to work. Then I could concentrate on coding. Please let me know how you see it.

OK. I promise to get it to work.

dpolivaev commented 2 years ago
collabs
dpolivaev commented 2 years ago

I think you can access the freeplane-docs repo settings, right?

macmarrum commented 2 years ago

Yes, I can. Thanks

2022-09-22_18,13,52

macmarrum commented 2 years ago

I have no access to Environments. The environment github-pages needs to be extended to accept from main branch.

dpolivaev commented 2 years ago

Done

dpolivaev commented 2 years ago

Replaced gh-pages by main branch

macmarrum commented 2 years ago

Done. It works OK: tested with #89