Add release date to track metadata

freerange / jam-coop

A platform co-operative for musicians and fans

https://jam.coop

GNU Affero General Public License v3.0

57 stars 2 forks source link

Add release date to track metadata #223

Closed chrislo closed 1 month ago

chrislo commented 1 month ago

This PR reworks #222 to get it ready to merge.

@lenikadali - thanks so much for your hard work on this! I've made a couple of small changes:

I squashed your commits together and added a bit of explanation in the commit message to document what you and @floehopper discussed about metadata field names
I added a more "end to end" test that extracts the metadata using ffprobe to make it a bit easier for us to change the metadata fields in the future and have some confidence that ffmpeg is doing the right thing.

chrislo commented 1 month ago

I'm pretty happy with where this has got to, so I plan to land it tomorrow. I don't think it's worth re-transcoding every file currently in the system to have the new metadata field, but it is something we could do - I don't think the background job machine is working very hard generally so it might be practical to retranscode to keep everything consistent.

lenikadali commented 1 month ago

@chrislo thanks a lot for getting to this as promised 🙌🏿

I'm pretty happy with where this has got to, so I plan to land it tomorrow. I don't think it's worth re-transcoding every file currently in the system to have the new metadata field, but it is something we could do - I don't think the background job machine is working very hard generally so it might be practical to retranscode to keep everything consistent.

Makes sense. In any case, it looks like something we can revisit should we find that it is having a disproportionate impact on performance.