search

freerange / mocha

A mocking and stubbing library for Ruby
https://mocha.jamesmead.org
Other
1.23k stars 158 forks source link

Add frozen_string_literal to mockery #669

Closed radville closed 3 months ago

radville commented 3 months ago

Description

This adds the magic comment for making string literals frozen in Mockery. This PR also purposely allows the string in #mocha_inspect to remain unfrozen with by duplicating it since that behavior relies on an unfrozen string. I couldn't use +'' because that method isn't supported in earlier versions of Ruby.

Context

There is a deprecation warning for chilled strings merged recently in Ruby: https://github.com/ruby/ruby/commit/12be40ae6be78ac41e8e3f3c313cc6f63e7fa6c4

With that change we started to see a chilled string warning for the string in #mocha_inspect.

floehopper commented 3 months ago

@radville Many thanks for the nudge to sort this out. I decided to solve it a slightly different way in 55dd0fca85a693d85b95e3fdbf07750988f8e48a and to group it with some other Ruby v3.4-related fixes in #672.