search

freesunshine0316 / neural-graph-to-seq-mp

Code corresponding to our paper "A Graph-to-Sequence Model for AMR-to-Text Generation"
137 stars 26 forks source link

Using zero for padding #7

Closed MingjieChen closed 5 years ago

MingjieChen commented 5 years ago

Hi,

Just a little question, not sure I am correct. You are using "0" to pad maxtrix. But in maxtrix "in_neight_indices", there could be two kinds of "0". One is padding "0", the other is the first node's indice (should be "0"). Should there be some problem if this conflicts of "0"?

Thanks

freesunshine0316 commented 5 years ago

For neighborhood 0 is not associated with any embedding vectors, and we use a 3D mask for the neighborhoods. So it doesn't matter.