search

freeswitch / spandsp

SpanDSP is a low-level signal processing library that modulates and demodulates signals commonly used in telephony, such as the "noise" generated by a fax modem or DTMF touchpad.
Other
152 stars 120 forks source link

install the private/v80.h header file #59

Open tmancill opened 1 year ago

tmancill commented 1 year ago

Hi. I noticed this when attempting to build freeswitch. It looks like private/v80.h needs to be installed along with expose.h. The reference to private/v80.h was added in d8dfbd74.

making all mod_spandsp
make[4]: Entering directory '/tmp/sources/freeswitch/src/mod/applications/mod_spandsp'
  CC       mod_spandsp_la-mod_spandsp.lo
In file included from /usr/local/include/spandsp.h:154,
                 from mod_spandsp.h:50,
                 from mod_spandsp.c:39:
/usr/local/include/spandsp/expose.h:69:10: fatal error: spandsp/private/v80.h: No such file or directory
   69 | #include <spandsp/private/v80.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[4]: Leaving directory '/tmp/sources/freeswitch/src/mod/applications/mod_spandsp'

This PR also includes a tweak to autogen.h, which carps about the ./config directory that already exists. I'm happy to split that into a separate PR, or modify this one to remove the mkdir entirely. I'm not sure under what circumstance the directory wouldn't exist since it is part of the repo.

freeswitch-ci-system[bot] commented 1 year ago

Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/freeswitch/spandsp/60/index.html

siadatism commented 1 year ago

I got to the same problem when building freeswitch. Thank you @tmancill for the solution. Can this PR be accepted sooner so the master branch becomes usable in the freeswitch build? I saw CI errors and they are irrelevant to this PR.

wangdong2023 commented 1 year ago

thank you for the solution. All the tutorials I read didn't mention this, I guess it comes with recent changes (though this repo seems to be rather quite). My first thought is to go back to previous versions, didn't find any tags or releases.

markjcrane commented 1 year ago

This is pull request is definitely needed for FreeSWITCH 1.10.10. Experienced the same problem.

Agreed that tags or releases would be really helpful.

killdashnine commented 1 year ago

Can confirm the same here. Also very much agree on tagging versions, it's now either pinning a specific commit or patching this manually.

xrobau commented 11 months ago

Note that freeswitch itself ALSO needs fixes - see ticket https://github.com/signalwire/freeswitch/issues/2282 and linked patch

https://github.com/xrobau/freeswitch-ubuntubuilder/commit/492a713f318bc64ddc70904850ff9ef7aa97761a#diff-aa73d3346e8371c37fd4c51934f9b1902f459752244c32ddb7dea4a92af5ded8