search

freetdi / tdlib

Other
12 stars 5 forks source link

Macro names #9

Closed spth closed 7 years ago

spth commented 7 years ago

tdlib exposes some macros. To reduce the risk of name conflicts, these should be renamed to have a common tdlib-specific prefix.

Currently, some macros have no prefix at all. Some have prefix TD. Some have prefix TDLIB. One could also choose a different prefix.

I can make the required changes, but I need to know which prefix I should use. Personally, I'd prefer TDLIB (TD seems a bit short, and thus more likely to leave potential name conflicts).

Philipp

felix-salfelder commented 7 years ago

thanks, this looks good.

there is some historic preprocessor macro abuse going on between gala and tdlib. something with bundled properties. will try to come up with a workaround, then merge.

(the resaon why this "succeds" with clang++, is that this part is disabled for clang, because -fprofile strangely different in clang++...)

felix-salfelder commented 7 years ago

this is fixed with your PR #12