Beats between bars not parsed properly -- beaming groups extend too far

[GoogleCodeExporter]

Found an ancient bug in parsebww.js ...

Goes back to my first parser and I never caught it.

BWW uses a 'beat' (tab) between groups of notes to "separate" beaming. 
That was never parsed correctly.. therefore, beaming will encompass a whole
group of notes that it shouldn't.

This can be fixed, but it will take it might cause breakage in the current
beaming routines.

At this might be a co-operative fix that involves multiple files, suggest
we wait for the code base to remerge back to the trunk and stabilize before
fixing.

Original issue reported on code.google.com by Jeremy.Starcher@gmail.com on 10 May 2010 at 7:59

Attachments:

• SimpleGifts.PNG

[GoogleCodeExporter]

Parsing the beat marker shouldn't create a problem with the beaming, as long as 
the
parser ineects the sectionEnd pseudo elements correctly (ie. inject the end of 
the
beam group, then inject the beat element). 

This will work for BWW but not for ABS as ABC doesn't have beat markers. An ABC
parser is going to have to accumulate note durations in order to beam note 
groups
properly. Maybe we should implement that for BWW as an enhancement?

Waiting for merge back to trunk sounds like a good idea. 

Original comment by pipemakertjm@gmail.com on 10 May 2010 at 8:24

[GoogleCodeExporter]

I've always been in favor of rebeaming ... so when we add it to the ABC, it 
should be
fairly trivial to make it work on anything once it imported.

The code to accumulate beat counts already exists and could be factored out of 
its
current location and put as part of the "post-import" process.  Minor changes 
will
need to be done to count beats in voltas (or rather, ignore everything but the 
first
pass) but that should be trivial as well.

Original comment by Jeremy.Starcher@gmail.com on 11 May 2010 at 3:20

[GoogleCodeExporter]

This issue was closed by revision r153.

Original comment by Jeremy.Starcher@gmail.com on 23 May 2010 at 3:10

• Changed state: Fixed