freezy / VisualPinball.Engine

:video_game: Visual Pinball Engine for Unity
https://docs.visualpinball.org
GNU General Public License v3.0
398 stars 62 forks source link

The BallRingCounterSystem is not required anymore #380

Closed simonbethke closed 2 years ago

simonbethke commented 2 years ago

I reversed a bit what the BallSpinHack is and what it is used for:

The BallSpinHack is a system which checks old positions in order to find if the ball is still moving. If it is not moving anymore the angular momentum is dampened. For that it utilizes the BallRingCounter and this ball ring counter even has an own system.

The BallRingCounter has been introduced in VPX for ball-trails. As ball-trails are either not required anymore or if required are done by unity stuff this system is not required anymore. And actually the trails itself have already been removed.

Of course VPX grew not only historically but also hysterically. In this case that means that the positions for the trails have simply been repurposed for the spinhacksystem.

As the spinhacksystem is 'only' used to apply playfield friction to the ball I suggest to remove both systems and add the dampening back in later on when implementing playfield friction.