Closed jsm174 closed 2 years ago
Also, after this PR is merged, we will update VisualPinball.Engine.PinMAME
to reference the latest VPE.
Merging #407 (4054338) into master (6cf623c) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 83.34% 83.34%
=======================================
Files 128 128
Lines 7081 7081
=======================================
Hits 5902 5902
Misses 1179 1179
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8c55cd0...4054338. Read the comment docs.
After trying to make a build of Rock that target
osx-arm64
andosx-x64
, we ran into some issues, see here.The solution is to use dual architecture binaries.
We created dual architecture binaries for
libpinmame
, see here. We also created dual architecture binaries fornetminiz
, see here.Note: NetVips does not currently have dual architecture binaries. We could use lipo on them, but then we would have to make the
.csproj
that executes commands only for osx, and that doesn't seem right at this time -- and since NetVips isn't used for Standalone builds, this isn't an issue.This PR refactors the
osx-arm64
/osx-x64
plugins folders toosx
,osx/arm64
, andosx/x64
. All*.meta
files have been updated accordingly.This PR also updates some outdated dependencies, and updates Unity to
2021.3.0f1
.