search

freezy / VisualPinball.Engine

:video_game: Visual Pinball Engine for Unity
https://docs.visualpinball.org
GNU General Public License v3.0
396 stars 62 forks source link

doc update supported Unity version in user documentation #423

Closed empty-set closed 2 years ago

empty-set commented 2 years ago

previous version of documentation suggests installing an earlier version of Unity

empty-set commented 2 years ago

This makes sense, I didn't understand how the suggestion of the latest works in unity. I'll make another pass

empty-set commented 2 years ago

I've change made a follow up change to include direct links to the unity package and unity download archive. I did this instead of including complicated directions within unity hub to get the same link. Unfortunately the protocol of unity:// is supported by the linkify process for the documentation. Otherwise this could be even easier.

empty-set commented 2 years ago

@freezy it looks like all the PRs are held up from a unit test build issue

freezy commented 2 years ago

Yeah, I think it's because it's your repo and the license keys for the CI aren't set up for that.

freezy commented 2 years ago

Looks all good. Cheers!

jsm174 commented 2 years ago

and the license keys for the CI aren't set up for that.

Yes, forks are not allowed to access a base repos secrets.

For future PRs, you would need to add the following secrets:

image

To get a license, you'd could make a dummy branch with an activation workflow. See: https://game.ci/docs/github/activation#personal-license

empty-set commented 2 years ago

@jsm174 I introduced this PR through the "Improve this document" feature of the documentation. I imagine this will be a recurring problem for changes made this way.

jsm174 commented 2 years ago

Understood.

You would just need the add these secrets here:

https://github.com/empty-set/VisualPinball.Engine/settings/secrets/actions