search

freezy / VisualPinball.Engine

:video_game: Visual Pinball Engine for Unity
https://docs.visualpinball.org
GNU General Public License v3.0
396 stars 62 forks source link

doc: Add Unity License Secrets Instructions #424

Closed empty-set closed 2 years ago

empty-set commented 2 years ago

Unity Secrets must be configured in GitHub before automated builds will complete. Attempting to make this easier for future developers

empty-set commented 2 years ago

My Build is still failing so I might need to make some modifications to the instructions :) The changes in the PR describe exactly the steps I've taken. These were adapted from this link. https://game.ci/docs/github/activation#personal-license I'm using a personal license, and I did receive a proper ulf.

jsm174 commented 2 years ago

hmm. I think maybe we should just include the activation workflow in the repo, so we don't have to make the instructions so complicated. I'll look in it.

empty-set commented 2 years ago

hmm. I think maybe we should just include the activation workflow in the repo, so we don't have to make the instructions so complicated. I'll look in it.

I would be ok with this, the workflow will need to be modified to not include the on: push since it will only need to run once.

The original instructions suggest using on: workflow_dispatch: {} and manually running the action. I was unable to manually run actions in GitHub, my UI in GitHub actions does not match the screenshots.

Also my build is still failing so my instructions must also be missing something?