freezy / VisualPinball.Engine

:video_game: Visual Pinball Engine for Unity
https://docs.visualpinball.org
GNU General Public License v3.0
396 stars 62 forks source link

Use LivecatchBounceMultiplier to reduce angular momentum instead of nulling it. #439

Open Cupiii opened 2 years ago

Cupiii commented 2 years ago

Currently, if a livecatch happens, angular momentum (only for x and y) is nulled, while livecatchbounceMultiplier is only used on velocity.

It could be tested, if the livecatches feel better, when the liveCatchBounceMultiplier (which is for example 0.2 for a slightly inaccurate livecatch) is not only applied to velocity, but also to the angular momentum.

    ball.Velocity -= collEvent.HitNormal * normalSpeed * liveCatchBounceMultiplier;
    ball.AngularMomentum.x = 0;
    ball.AngularMomentum.y = 0;

-->

    ball.Velocity -= collEvent.HitNormal * normalSpeed * liveCatchBounceMultiplier;
    ball.AngularMomentum.x *= liveCatchBounceMultiplier;
    ball.AngularMomentum.y *= liveCatchBounceMultiplier;

possibly only angular momentum in the direction of the collision-normal could be reduced. (like for velocity, or the same amount of the overall velocity reduction, otherwise calculation would be quite hard.)