search

freezy / dmd-extensions

A toolbox for virtual pinball dot matrix displays.
GNU General Public License v2.0
127 stars 54 forks source link

frame buffer issue/crash if both scaletohd and flipvertically enabled - log attached #375

Closed CarnyPriest closed 1 year ago

CarnyPriest commented 1 year ago

DmdDevice.log

Hi, I have a frame buffer issue when enabling scaletohd. I have a Pinball 2000 style cabinet, so I do also have flipvertically enabled.

The upscale does work if I do not enable flipvertically, but then of course the reflected image would be reversed for players.

Not a deal breaker, standard 128x32 scale works great!

freezy commented 1 year ago

This should be solved in the upcoming PR (#374), I'll let you know when there's something to test!

CarnyPriest commented 1 year ago

Excellent! Thanks!

freezy commented 1 year ago

Try this build.

Just as a note, the scaling settings changed a bit, although it should be retro-compatible.

Before, we had:

; enable hd scaling
scaletohd = true

; doubler or scale2x
scalermode = doubler

Now, we have:

; none, doubler or scale2x
scalermode = doubler

So in your case, you can just remove scaletohd. In case you had it disabled, scaletohd = false will still work, but you can also disable it by setting scalermode to none.

CarnyPriest commented 1 year ago

Sorry, missed this. But it works with v2.2.0-beta1. Thanks!

freezy commented 1 year ago

Fixed in #374.