search

freezy / dmd-extensions

A toolbox for virtual pinball dot matrix displays.
GNU General Public License v2.0
127 stars 54 forks source link

CFTBL colors wrong some scenes pal/vni 2.2.1-SNAPSHOT-r12 (5baf7ae) (x64) #422

Closed passionforpins closed 1 year ago

passionforpins commented 1 year ago

CFTBL colors wrong some scenes pal/vni 2.2.1-SNAPSHOT-r12 (5baf7ae) (x64) Lots of green where there should be black or gray (filmstrip) Some scenes go totally gray scale. Same in 32 bit. cftbl_l4.zip

 [3] 2023/09/09 17:40:44.127  INFO | Starting DmdDevice API 2.2.1-SNAPSHOT-r12 (5baf7ae) (x86) through VPinballX.exe. 
 [3] 2023/09/09 17:40:44.143  INFO | Assembly located at E:\vpinball\VPinMAME\DmdDevice.dll 
 [3] 2023/09/09 17:40:44.143  INFO | Running in E:\vpinball\Tables\CFTBL 
 [3] 2023/09/09 17:40:44.162  INFO | Successfully loaded config from E:\vpinball\VPinMAME\DmdDevice.ini. 
 [3] 2023/09/09 17:40:44.205  INFO | [serum] Determined altcolor path from assembly path: E:\vpinball\VPinMAME\altcolor 
 [3] 2023/09/09 17:40:45.382  INFO | [dll] Open(0) 
 [3] 2023/09/09 17:40:45.382  INFO | [dll] Set_4_Colors_Palette(0, #000000, #0600D6, #E10FC1, #FF5820) 
 [3] 2023/09/09 17:40:45.383  INFO | Setting palette to 4 colors... 
 [3] 2023/09/09 17:40:45.383  INFO | [dll] PM_GameSettings(0, cftbl_l4, 1) 
 [3] 2023/09/09 17:40:45.383  INFO | Enabling game colorization 
 [3] 2023/09/09 17:40:45.383  INFO | Setting game name: cftbl_l4 
 [3] 2023/09/09 17:40:45.383  INFO | Setting color: #FFFF5820 
 [3] 2023/09/09 17:40:45.383  INFO | [serum] No colorization found at E:\vpinball\VPinMAME\altcolor\cftbl_l4... 
 [3] 2023/09/09 17:40:45.406  INFO | [plugin] pin2color.dll not found. 
 [3] 2023/09/09 17:40:45.406 ERROR | [plugin] Error loading plugin at pin2color.dll. 
 [3] 2023/09/09 17:40:45.406  INFO | [vni] Loading palette file at E:\vpinball\VPinMAME\altcolor\cftbl_l4\pin2dmd.pal... 
 [3] 2023/09/09 17:40:45.406  INFO | [vni] Loading virtual animation file at E:\vpinball\VPinMAME\altcolor\cftbl_l4\pin2dmd.vni... 
 [3] 2023/09/09 17:40:45.477  INFO | [vni] Loaded animation set VPIN v4, 364 animation(s) 
 [3] 2023/09/09 17:40:45.477  INFO | [vni] Animation Dimensions: 128x32 
 [3] 2023/09/09 17:40:45.477  INFO | Opening virtual display... 
[15] 2023/09/09 17:40:45.540  INFO | Found B2S, moving behind DMD. 
[15] 2023/09/09 17:40:45.558  INFO | Added VirtualDMD renderer. 
[15] 2023/09/09 17:40:45.574  INFO | [pinup] Starting cftbl_l4... 
[15] 2023/09/09 17:40:45.574  INFO | Added PinUP renderer. 
[15] 2023/09/09 17:40:45.574  INFO | Transformation options: Resize=Fit, HFlip=False, VFlip=False 
[15] 2023/09/09 17:40:45.574  INFO | Just clearing palette, colorization is done by converter. 
[15] 2023/09/09 17:40:45.574  INFO | Applying default color to render graphs (#FFFF5820). 
[15] 2023/09/09 17:40:45.574  INFO | Setting up 2-bit Colorization Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 17:40:45.574  INFO |   == Listening to DmdDevice 2-bit Source for VNI Colorizer (Gray2) 
[15] 2023/09/09 17:40:45.587  INFO |   ** Linking converter VNI Colorizer to Virtual DMD... 
[15] 2023/09/09 17:40:45.587  INFO |     -> Connecting VNI Colorizer to Virtual DMD (ColoredGray2 -> ColoredGray2) 
[15] 2023/09/09 17:40:45.587  INFO |     -> Connecting VNI Colorizer to Virtual DMD (ColoredGray4 -> ColoredGray4) 
[15] 2023/09/09 17:40:45.587  INFO |     -> Connecting VNI Colorizer to Virtual DMD (ColoredGray6 -> ColoredGray6) 
[15] 2023/09/09 17:40:45.587  INFO |   ** Linking converter VNI Colorizer to PinUP Writer... 
[15] 2023/09/09 17:40:45.587  WARN |     -- Destination doesn't support colored 2-bit frames from converter, ignoring converter. 
[15] 2023/09/09 17:40:45.587  WARN |     -- Destination doesn't support colored 4-bit frames from converter, ignoring converter. 
[15] 2023/09/09 17:40:45.587  WARN |     -- Destination doesn't support colored 6-bit frames from converter, ignoring converter. 
[15] 2023/09/09 17:40:45.587  INFO |   -> Connecting DmdDevice 2-bit Source to PinUP Writer (Gray2 -> Gray2) - not deduped 
[15] 2023/09/09 17:40:45.587  INFO | Setting up 4-bit Colorization Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 17:40:45.587  INFO |   == Listening to DmdDevice 4-bit Source for VNI Colorizer (Gray4) 
[15] 2023/09/09 17:40:45.587  INFO |   ** Linking converter VNI Colorizer to Virtual DMD... 
[15] 2023/09/09 17:40:45.587  INFO |   ** Linking converter VNI Colorizer to PinUP Writer... 
[15] 2023/09/09 17:40:45.587  WARN |     -- Destination doesn't support colored 2-bit frames from converter, ignoring converter. 
[15] 2023/09/09 17:40:45.587  WARN |     -- Destination doesn't support colored 4-bit frames from converter, ignoring converter. 
[15] 2023/09/09 17:40:45.587  WARN |     -- Destination doesn't support colored 6-bit frames from converter, ignoring converter. 
[15] 2023/09/09 17:40:45.587  INFO |   -> Connecting DmdDevice 4-bit Source to PinUP Writer (Gray4 -> Gray4) - not deduped 
[15] 2023/09/09 17:40:45.587  INFO | Setting up RGB24 Passthrough Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 17:40:45.587  INFO |   -> Connecting DmdDevice RGB24 Source to Virtual DMD (Rgb24 -> Rgb24) 
[15] 2023/09/09 17:40:45.587  INFO |   -> Connecting DmdDevice RGB24 Source to PinUP Writer (Rgb24 -> Gray4) 
[15] 2023/09/09 17:40:45.587  INFO | Setting up Alphanumeric Passthrough Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 17:40:45.926  INFO | Creating FBOs for 128x32 
 [3] 2023/09/09 17:42:43.772  INFO | [dll] Close(0) 
 [3] 2023/09/09 17:42:43.772  INFO | Closing up. 
 [3] 2023/09/09 17:42:43.804  INFO | Source for 5 renderer(s) stopped. 
 [3] 2023/09/09 17:42:43.804  INFO | Source for 2 renderer(s) stopped. 
 [3] 2023/09/09 17:42:43.804  INFO | Source for 2 renderer(s) stopped. 
 [3] 2023/09/09 17:42:43.804  INFO | Source for 0 renderer(s) stopped.
passionforpins commented 1 year ago

forgot to say using vpx 10.7.4 x64 and x86 vpinmame 3.6-sc-603

MikedaSpike commented 1 year ago

I use the same colored files for Zen FX and see that some scenes are also incorrect collered within ZEN FX I hope I can hop on with this issue as well. Logfile from ZEN FX DmdDevice.log

passionforpins commented 1 year ago

I think it's a good idea as long as freezy can keep up with us :) I just found fishtales perfect in vpx so hopped into your issue as well

freezy commented 1 year ago

I use the same colored files for Zen FX and see that some scenes are also incorrect collered within ZEN FX

Problably same issue as #420, but haven't checked.

@passionforpins I have trouble finding the scene that is wrong. It would be awesome if you could:

With the latest build, you can also test coloring on dump files directly:

dmdext play -f "C:\Visual Pinball\VPinMAME\dmddump\cftbl_l4.txt" --use-ini
passionforpins commented 1 year ago

man there is a ton of badly colored scenes. The easter egg "no more bad food" for example, goes all gray. Hold flipper buttons when snackbar is completed. Most transitions that shows the film reel left side of dmd nearly always show green, should be black and white. I've never tried a color dump but will have a go at it when I have time

passionforpins commented 1 year ago

I created a dmddump folder in altcolor, altcolor\cftbl_l4 and under vpinmame. No dump txt files were created. do I need to enable something in dmddevice.ini?

freezy commented 1 year ago

It's VPM that creates the dumps. AFAIK, external DMD and colorize must be both enabled, plus the folder must exist in the VPM folder, that's the condition. Here's my settings that worked for CFBL:

freezy commented 1 year ago

Maybe "Show DMD/Display window" must be enabled, too.

passionforpins commented 1 year ago

enable vpm dmd as well as external- ok will try that

passionforpins commented 1 year ago

Ok that works. It creates the dump in \vpinmame\dmddump Now, I played a game and killed it on the last scene that went all gray. When I looked at the txt file all I see is literally machine language. There are sections separated though so I'm totally guessing but this is the last section when I killed the game. There is also a .raw file created in that folder. 

0x1ef2af7d
00000000000000030033330000030003300003000000300333300330000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000330000030000300030030030000003000000303003000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000030000300003000000030300000030000003003003000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000030003000003330003300333000033300030003003000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000030003000003003000030300300030030030003003000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000030003000003003030030300300030030030003003000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000333003000300330003300033003003300030000330000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000300000000000000003000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000003000000000000000030000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000033303330033330333003330333003330000033000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000300003003030000300300300030030000000300300000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000300003330033300300300300030003300000033000000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000300003003030000300300300030000030000300300000000000000000000000000000000000000000000
00000000000000000000000000000000000000000000033303003033330333003330030033300000033000000000000000000000000000000000000000000000
freezy commented 1 year ago

image

That's your frame - you sure that's the one that fails?

If you make the font small in the text editor, you should be able to recognize fairly easily the frames. The .raw file you can ignore.

passionforpins commented 1 year ago

Learn something new every day! Amazing. Ok here's the bad section cftbl-end-gray.zip

freezy commented 1 year ago

Great, could reproduce, thanks!

passionforpins commented 1 year ago

Thats just one :)

freezy commented 1 year ago

I assume it's the same bug for most of those..

freezy commented 1 year ago

Well, I have the same behavior with the plugin. Maybe a buggy VNI?

passionforpins commented 1 year ago

I think you're right. I just tried with 3 older dll's from lucky and yours and same bad coloration on the same scenes every time. I'm guessing, like you, it's a bugged vni. Unless @MikedaSpike has more suggestions or different results I say close the issue.

MikedaSpike commented 1 year ago

I played some games this morning, but the scenes down's look different than previous version. I noticed I have VNI and PAL from 2021 and you go old ones (2019) cftbl_l4.zip Can you try this file Cliffy? I htink this issue can be closed

passionforpins commented 1 year ago

OMG- so sorry I had an old version Freezy. Thanks @MikedaSpike I ran this 2021 version and all scenes are colored correctly. @freezy called it- I had a buggy vni. Closing this one