search

freezy / dmd-extensions

A toolbox for virtual pinball dot matrix displays.
GNU General Public License v2.0
127 stars 54 forks source link

Rocky and Bullwinkle colors change some scenes pal/vni 2.2.1-SNAPSHOT-r12 (5baf7ae) (x64) (x86) #424

Closed passionforpins closed 1 year ago

passionforpins commented 1 year ago

Rocky and Bullwinkle rab_320 mostly good but glitches in transitions and some scenes with a lot of action. Example, at skill shot bullwinkles antlers turn from yellow (correct) to cyan (incorrect) vpx 10.7.4 x64 and x86 vpinmame 3.6-sc-603

 [3] 2023/09/09 18:03:05.104  INFO | Starting DmdDevice API 2.2.1-SNAPSHOT-r12 (5baf7ae) (x86) through VPinballX.exe. 
 [3] 2023/09/09 18:03:05.119  INFO | Assembly located at E:\vpinball\VPinMAME\DmdDevice.dll 
 [3] 2023/09/09 18:03:05.119  INFO | Running in E:\vpinball\Tables\Bullwinkle 
 [3] 2023/09/09 18:03:05.134  INFO | Successfully loaded config from E:\vpinball\VPinMAME\DmdDevice.ini. 
 [3] 2023/09/09 18:03:05.172  INFO | [serum] Determined altcolor path from assembly path: E:\vpinball\VPinMAME\altcolor 
 [3] 2023/09/09 18:03:06.278  INFO | [dll] Open(0) 
 [3] 2023/09/09 18:03:06.278  INFO | [dll] Set_4_Colors_Palette(0, #000000, #0600D6, #E10FC1, #FF5820) 
 [3] 2023/09/09 18:03:06.278  INFO | Setting palette to 4 colors... 
 [3] 2023/09/09 18:03:06.278  INFO | [dll] PM_GameSettings(0, rab_320, 1) 
 [3] 2023/09/09 18:03:06.278  INFO | Enabling game colorization 
 [3] 2023/09/09 18:03:06.278  INFO | Setting game name: rab_320 
 [3] 2023/09/09 18:03:06.278  INFO | Setting color: #FFFF5820 
 [3] 2023/09/09 18:03:06.288  INFO | [serum] No colorization found at E:\vpinball\VPinMAME\altcolor\rab_320... 
 [3] 2023/09/09 18:03:06.288  INFO | [plugin] pin2color.dll not found. 
 [3] 2023/09/09 18:03:06.288 ERROR | [plugin] Error loading plugin at pin2color.dll. 
 [3] 2023/09/09 18:03:06.288  INFO | [vni] Loading palette file at E:\vpinball\VPinMAME\altcolor\rab_320\pin2dmd.pal... 
 [3] 2023/09/09 18:03:06.288  INFO | [vni] Loading virtual animation file at E:\vpinball\VPinMAME\altcolor\rab_320\pin2dmd.vni... 
 [3] 2023/09/09 18:03:06.444  INFO | [vni] Loaded animation set VPIN v4, 1719 animation(s) 
 [3] 2023/09/09 18:03:06.444  INFO | [vni] Animation Dimensions: 128x32 
 [3] 2023/09/09 18:03:06.444  INFO | Opening virtual display... 
[15] 2023/09/09 18:03:06.492  INFO | Found B2S, moving behind DMD. 
[15] 2023/09/09 18:03:06.507  INFO | Added VirtualDMD renderer. 
[15] 2023/09/09 18:03:06.507  INFO | [pinup] Starting rab_320... 
[15] 2023/09/09 18:03:06.507  INFO | Added PinUP renderer. 
[15] 2023/09/09 18:03:06.507  INFO | Transformation options: Resize=Fit, HFlip=False, VFlip=False 
[15] 2023/09/09 18:03:06.507  INFO | Just clearing palette, colorization is done by converter. 
[15] 2023/09/09 18:03:06.507  INFO | Applying default color to render graphs (#FFFF5820). 
[15] 2023/09/09 18:03:06.522  INFO | Setting up 2-bit Colorization Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 18:03:06.522  INFO |   == Listening to DmdDevice 2-bit Source for VNI Colorizer (Gray2) 
[15] 2023/09/09 18:03:06.522  INFO |   ** Linking converter VNI Colorizer to Virtual DMD... 
[15] 2023/09/09 18:03:06.522  INFO |     -> Connecting VNI Colorizer to Virtual DMD (ColoredGray2 -> ColoredGray2) 
[15] 2023/09/09 18:03:06.522  INFO |     -> Connecting VNI Colorizer to Virtual DMD (ColoredGray4 -> ColoredGray4) 
[15] 2023/09/09 18:03:06.522  INFO |     -> Connecting VNI Colorizer to Virtual DMD (ColoredGray6 -> ColoredGray6) 
[15] 2023/09/09 18:03:06.522  INFO |   ** Linking converter VNI Colorizer to PinUP Writer... 
[15] 2023/09/09 18:03:06.522  WARN |     -- Destination doesn't support colored 2-bit frames from converter, ignoring converter. 
[15] 2023/09/09 18:03:06.522  WARN |     -- Destination doesn't support colored 4-bit frames from converter, ignoring converter. 
[15] 2023/09/09 18:03:06.522  WARN |     -- Destination doesn't support colored 6-bit frames from converter, ignoring converter. 
[15] 2023/09/09 18:03:06.522  INFO |   -> Connecting DmdDevice 2-bit Source to PinUP Writer (Gray2 -> Gray2) - not deduped 
[15] 2023/09/09 18:03:06.522  INFO | Setting up 4-bit Colorization Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 18:03:06.522  INFO |   == Listening to DmdDevice 4-bit Source for VNI Colorizer (Gray4) 
[15] 2023/09/09 18:03:06.522  INFO |   ** Linking converter VNI Colorizer to Virtual DMD... 
[15] 2023/09/09 18:03:06.522  INFO |   ** Linking converter VNI Colorizer to PinUP Writer... 
[15] 2023/09/09 18:03:06.522  WARN |     -- Destination doesn't support colored 2-bit frames from converter, ignoring converter. 
[15] 2023/09/09 18:03:06.522  WARN |     -- Destination doesn't support colored 4-bit frames from converter, ignoring converter. 
[15] 2023/09/09 18:03:06.522  WARN |     -- Destination doesn't support colored 6-bit frames from converter, ignoring converter. 
[15] 2023/09/09 18:03:06.522  INFO |   -> Connecting DmdDevice 4-bit Source to PinUP Writer (Gray4 -> Gray4) - not deduped 
[15] 2023/09/09 18:03:06.522  INFO | Setting up RGB24 Passthrough Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 18:03:06.522  INFO |   -> Connecting DmdDevice RGB24 Source to Virtual DMD (Rgb24 -> Rgb24) 
[15] 2023/09/09 18:03:06.522  INFO |   -> Connecting DmdDevice RGB24 Source to PinUP Writer (Rgb24 -> Gray4) 
[15] 2023/09/09 18:03:06.522  INFO | Setting up Alphanumeric Passthrough Graph for 2 destination(s) [ Virtual DMD, PinUP Writer ] 
[15] 2023/09/09 18:03:06.814  INFO | Creating FBOs for 128x32 
 [3] 2023/09/09 18:04:13.030  INFO | [dll] Close(0) 
 [3] 2023/09/09 18:04:13.030  INFO | Closing up. 
 [3] 2023/09/09 18:04:13.038  INFO | Source for 5 renderer(s) stopped. 
 [3] 2023/09/09 18:04:13.038  INFO | Source for 2 renderer(s) stopped. 
 [3] 2023/09/09 18:04:13.038  INFO | Source for 2 renderer(s) stopped. 
 [3] 2023/09/09 18:04:13.038  INFO | Source for 0 renderer(s) stopped.
freezy commented 1 year ago

Same as #422, it would be so much easier for me if I had a scene in a dump file. If you have a game you suspect that has the same problem as the other ones but is easier to reproduce, that's fine, too.

MikedaSpike commented 1 year ago

This is from attract mode : 

0x0582dbd7
03111111111111131011111331111101111101313111331010103330333303303303301000000000000000000000000000000000000000000000000000000111
31131313131313131013131331313101030103111313111010103333330333333333301000003130000133333133300013333100000333331000000000000101
11303030303030301011111111111101111101111131111010100111333330331111001000013130000333331333300333131310003333313300011111000111
11300000000000000000000000000000011110000000000110101111113333111111101000133330000333313131303133333333013133333130011001000000
33000333331000333310033331300000011111111111111110111111111111111111111000333330000133000000003130000313031300003330011001000333
11100313331303133313033131330000000000000000000000000000000000000000000000003130000333000000003130000333033300003330011111000111
00000330003303300033033000130000333000333003333330000033333300333001111000003130000331000000003130000331000000003130011001000311
11110130003301300033031000130003300303300300033000000000330003300301331000003310000333000000003310000131000000003310011001000013
00010330003303300033033000330003300003300300033000000000330003300301301000003130000133333130003313333331000313333300011001010331
00010333133303333313013313300003303303300300033000000000330003300301331000003330000333313333000331313331000131333000000000000011
11110331333003333313033131330003300303300300033000000000330003300301331000003310000333313133300033133333000313333300011110000311
00000310310003100013033000330003300303300300033000000000330003300301331000003130000000000033300000000131000000003130011001000013
11110330031003300033013000330000333300333000033000000000330000333001331000003330000000000031300000000331000000003330011001000331
01010130003301300033033000330000000000000000000000000000000000000001301000003330000000000033300000000331000000001130011001000111
11110330003303300033033313330000001111001101111111111111111011111101301000003330000331000033303330000133033300001330011001000333
11110330001301300031013333300000011331101101303030303030301010110101331000003130000333000033103130000331013300003310011001000000
10000000000000000000000000000000013333103301303030303030301011111101331000333331300133333133303333133133033331333330011110010111
10011100111111111111011111030111013033101101333311111313331010330101331000133313100013333313000313333130003333133300000000000101
00133310101030000101010110003011013303103301311133333131131010330101331000333133300003133310000033131300000331331000000000000111
10133310111033030111011100010301013333101101303030303030301011111101301000000000000000000000000000000000000000000000000000000000
00133310101333333101010110011030011331103301303030303030301010110101331011011101111100033133133133133133133133133133111111111111
30011100111111111111011111011103001111001101111111111111111011111101111011011101111103313313313313313131331331331331331111111111
10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000111
30111111110011100110010000011111101100101111100000110101011111011110011111001110000001100010111110011100110010110110010111110101
10101100110110010111010000000110001100101100000000110101011001011010011001011001000001110110110010110010110010110111010110000101
00111011010110010110110000000110001100101100000000110101011001011010011001011000000001101010110010110000110010110110110110000101
10131100110110010110010000000110001111101111000000110101011111011111011111011000000001100010111110110000111110110110010111100101
00111111110110010110010000000110001100101100000000110101011001011001011001011000000001100010110010110000110010110110010110000101
10101100110110010110010000000110001100101100000000111011011001011001011001011001000001100010110010110010110010110110010110000101
10111011010011100110010000000110001100101111100000010001011001011111011001001110000001100010110010011100110010110110010111110101
10101100110000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000111
10111111110131313101111111111111111011101111111111111111111111111111111111101111111111111111111111111111111110111111111111111111

this is from R12 : Naamloos1 and this is a correct colored: Naamloos

passionforpins commented 1 year ago

Yes even with R13 the colors in many scenes still wrong. Bullwinkles antlers still cyan on the skill shot, should be yellow, for example rab_320.txt

freezy commented 1 year ago

@passionforpins I also got the same coloring with the plugin.

You can easily test both with the dump by running dmdext play -f "C:\Visual Pinball\VPinMAME\dmddump\rab_320.txt" --use-ini, and commenting/enabling plugin.0.path64 in DmdExt.ini, using the unlocked VNI plugin posted in the 2.2.0 final post.

Let me know if you can reproduce a sequence that works with the plugin but not with the native VNI implementation.

passionforpins commented 1 year ago

Yes I tried with some much older dll's too and exact same scenes have same wrong colors so again it must be a buggy vni. Close please since its not a dll problem