search

fregante / GhostText

👻 Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).
https://GhostText.fregante.com
MIT License
3.28k stars 117 forks source link

Change keybinding on Firefox? #113

Closed dudelson closed 6 years ago

dudelson commented 6 years ago

The README says that the key binding can be changed, but this appears to be chrome-specific advice only. On firefox, Ctrl-Shift-h opens the history, and Ctrl-Shift-k opens the browser console, so these keys appear to be interpreted by firefox instead of being passed to GhostText. I would like to change the keybinding, but there is no option in the GhostText extension preferences that allows me to do this.

KatieK2 commented 6 years ago

Please do create some way to change the key binding for Firefox. When I use "Control Shift k" in Firefox, I expect to get the browser dev tools with focus on the Console tab. However, with GhostText enabled, I instead get a red error box saying "No textarea elements on this page". Inspecting this element in the DOM reveals that it has these classes: ghost-text-message ghost-text-message-error. GhostText is interfering with Firefox's (Firefox Quantum v57.0.2 (64-bit) in Windows 10) default keyboard commands.

duncan-bayne commented 6 years ago

Would you accept a PR to fix this? It's the only pain point I'm experiencing with this otherwise wonderful tool, which has made Firefox 57 bearable in the absence of It's All Text.

fregante commented 6 years ago

I see a lot of Firefox users coming from the old It's All Text. Sorry for the neglect!

Indeed Firefox does not yet offer a UI to change the key bindings like Chrome does, so for now I disabled the shortcuts there, v17.12.11.x

I disabled the keyboard shortcuts in Firefox until they provide the UI. Keep an eye on this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1303384

dudelson commented 6 years ago

Will do. Thanks!

Stvad commented 6 years ago

It'd be great to have at least some shortcut by default (non conflicting one), though

WJCFerguson commented 5 years ago

I'm puzzled why this is closed, given that it hasn't got a shortcut (no?) and is pending a Firefox fix that hasn't landed yet (?).

fregante commented 5 years ago

I disabled the keyboard shortcuts in Firefox until they provide the UI

Stvad commented 5 years ago

@bfred-it But that doesn't really help resolve the problem 🙁. As I mentioned above, having at least some non conflicting shortcut would be great, even if it could not be configured.

WJCFerguson commented 5 years ago

Ok, in that case I submitted issue #147 to request a keyboard shortcut.

Thank you for your efforts!