search

fregante / GhostText

đź‘» Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).
https://GhostText.fregante.com
MIT License
3.26k stars 116 forks source link

Alter suggested shortcut, and re-enable for Firefox. #159

Closed Lenbok closed 4 years ago

Lenbok commented 4 years ago

Firefox now has a built-in UI for editing extension shortcuts, so we can now re-enable the shortcut on Firefox, allowing users to update as they wish.

Closes #147

The problematic shortcuts have been updated to Ctrl-Alt-E as suggested in #147

[when GhostText as a temporary extension as described in https://github.com/GhostText/GhostText/issues/147#issuecomment-496150163 neither the button nor the shortcut actually trigger the toggle properly, but that seems unrelated to this]

fregante commented 4 years ago

I can’t change the default key, it will break it for existing users. This PR should just drop the dot-json command so it will be available for change in Firefox and update the readme to drop “Chrome” mentions.

fregante commented 4 years ago

❤ thank you!

Lenbok commented 4 years ago

Minor markdown tweaks pushed at the end. Good to go I think.

Lenbok commented 4 years ago

@fregante Can you please make a release now this has merged?

fregante commented 4 years ago

That’s strange, it’s setup to publish automatically.

Lenbok commented 4 years ago

https://addons.mozilla.org/en-US/firefox/addon/ghosttext/ shows last updated Dec 2017

fregante commented 4 years ago

I probably need to update the API key on travis

https://travis-ci.org/GhostText/GhostText

Lenbok commented 4 years ago

@fregante Any luck with this? I saw some deployment condition change on master, but it's still only the old release available on mozilla.

chaorace commented 4 years ago

Looks like TravisCI tried and failed to push the chrome build artifact. The firefox artifact never actually got pushed:


> GhostText-browser@0.0.0 release-cws /home/travis/build/GhostText/GhostText

> cd browser && webstore upload --auto-publish

Response code 400 (Bad Request)

{

    "error": "invalid_grant",

    "error_description": "Bad Request"

}

npm ERR! code ELIFECYCLE

npm ERR! errno 1

npm ERR! GhostText-browser@0.0.0 release-cws: `cd browser && webstore upload --auto-publish`

npm ERR! Exit status 1
chaorace commented 4 years ago

I noticed that sometimes the Chrome autodeployment seems to fail. Maybe the firefox deployment shouldn't short circuit when the chrome deployment fails (&& vs &), since that's an independent process: https://github.com/GhostText/GhostText/blob/5a8816317dcfab5b0ddd887724a8fa5dc9ec8808/package.json#L14

chaorace commented 4 years ago

@Lenbok Heads up, AMO autodeploy should be working again. I just tested it and your shortcut change is working great!

Lenbok commented 4 years ago

@chaorace Thanks for the reminder, working nicely for me now too!