fregante / GhostText

👻 Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).

https://GhostText.fregante.com

MIT License

3.26k stars 116 forks source link

Fix Mozilla Add-ons deployment #161

Closed chaorace closed 4 years ago

chaorace commented 4 years ago

Setup

Browser: Firefox Editor: Any

Description

The autodeploy for Firefox AMO fails to package the inputarea.js file, now that it's been re-enabled as part of #159 and #160 Building the package from scrach using webext works on my machine. I'm not yet sure why the autodeploy artifact is missing this specific file.

You can reproduce this issue by loading the latest release from the AMO. The issue is fatal and prevents the extension from working entirely.

fregante commented 4 years ago

Probably because & npm run release-amo does not wait any command preceding it. Can you implement it with npm-run-all?

Usage example https://github.com/sindresorhus/refined-github/blob/0b04d77a8f2ed3f28f5de428373acb04eccb0a14/package.json#L17

chaorace commented 4 years ago

I'll give it a shot, it's a little difficult to test once implemented though.

chaorace commented 4 years ago

@fregante PR submitted, hopefully this should do the trick

fregante commented 4 years ago

Thank you!

chaorace commented 4 years ago

I don't think npm-run-all likes that particular syntax. run-s is already a macro for sequential, so it's probably not hooked up to the --parallel/--sequential flags.

> GhostText-browser@0.0.0 deploy /home/travis/build/GhostText/GhostText

> run-s build update-version --parallel --continue-on-error release-cws release-amo

ERROR: Invalid Option: --parallel