Closed fregante closed 3 years ago
@fregante There is no blue glowing border as there was before. Is this intended?
Firefox on Linux GhostText test page here
Even if the HTTP server is not currently running, GhostText extension shows sucessfully connected and turns ON or, if already ON, the counter increases by one (indicating successful connection)
Does not connect / shows error that server is not running
Firefox (latest stable release) on Arch Linux GhostText test page here
@fregante I forgot to mention in the above post that only the extension icon indicates successful connection. The banner showing "Connected! You can switch to your editor" does not appear, nor does the console show "GhostText: Connected! You can switch to your editor" or "Sending -- characters"
Also, as I mentioned above, this issue exists only if the HTTP server is dead. Not if the websocket server is dead (i.e. HTTP server is working and sent the correct response, but the port number of the response does not point to a valid websocket server).
If a field is currently connected, then clicking the GhostText extension icon and selecting the connected field should disconnect it. It currently does not disconnect.
The selected field, if already connected, gets disconnected, but if not connected, then gets connected.
Firefox (latest stable release) on Arch Linux GhostText test page here
Ping @fregante
Thank you for the reports! I’m AFK for the next few days
I’m AFK for the next few days
@fregante How many days more? 😇
It is a textarea as mentioned here
The text does appear when we are typing, but as soon as the browser window is focused, all the text is gone from the browser window only. The text does not get deleted in the editor itself
Firefox on Arch Linux
This is a report testing the newer GhostText rewrite: ghosttext-20.11.27.zip
Context: https://github.com/GhostText/GhostText/issues/172
Please include what you're testing:
Browser? Editor? URL? Any issues that appear in the browser's console? Does the page work with the older version of GhostText? Does it work with Sublime Text 3?
Firefox 84.0
(Latest stable version on Ubuntu at the time of this writing.)
Tested with both:
Doom Emacs
Sublime Text 3 (Build 3211)
Ace
Yes, but the error is minor.
The error may also just relate to the 3rd party plugin for Emacs. As in: this is probably not an error with the extension itself.
This isssue occurs when text is sent from editor -> browser in Emacs ONLY. This issue does not occur with Sublime Text 3. Browser -> editor is fine and produces no errors.
This error also does not affect the transmission of text. Both the editor and browser send updates to each other with no text loss.
Here is the error. It is sent everytime a character is typed in Emacs -> browser:
Error:
selections is undefined 5 content.js:150
Offending code in content.js line 150:
receive(event) {
const {
text,
selections
} = JSON.parse(event.data);
if (this.field.value !== text) {
this.field.value = text;
}
this.field.selectionStart = selections[0].start; // <-- this is line 150
this.field.selectionEnd = selections[0].end;
}
I believe this is because the plugin for Emacs does not send any data on the current selection of text in the editor--it only sends the text itself.
No, the page does not work.
The page produces the error mentioned in this bug: https://github.com/GhostText/GhostText/issues/104#issue-263692210
This new error mentioned in the report also persists with the old version. However, I think it is because of the implemenetation of the 3rd party plugin for Emacs.
Yes, no errors.
TL;DR
We can probably close this issue: https://github.com/GhostText/GhostText/issues/104
Thank you Federico!
Ping @fregante for updates.....
Happy New Year to everybody :tada:
Thank you for the many reports! It looks like a lot of parts are still broken so it needs further work. The update was even rejected by Google so that confirms it 😬
The update was even rejected by Google so that confirms it
I didn't understand what you meant by that...
Using the latest Firefox and atomic chrome at editor.p5js.org.
Working great here with last Chrome and VimR. I love it! 😄
I've made a couple of PRs (https://github.com/GhostText/GhostText/pull/176 and https://github.com/GhostText/GhostText/pull/175). One to fix the Chrome focus after disconnection and another to not to ask for a textarea if there's an already selected one.
By the way, it works great with Slack messages! (the previous one didn't).
I opened a PR with some updates. Bear with me
Reddit (markdown mode) doesn't work
@subnut It's possible that Reddit still considers the field "untouched" becuse GhostText didn't send any events, so it blindly resets it. I resolved https://github.com/GhostText/GhostText/issues/42 so this should be
I believe this is because the plugin for Emacs does not send any data on the current selection of text in the editor--it only sends the text itself.
@coltoneakins Indeed! I considered making the error silent, but since selections
are part of the API, it should be fixed in the Emacs plugin (which is by third party, so you'll have to open an issue there). I think this is unrelated to Ace editor.
The update was even rejected by Google so that confirms it
I didn't understand what you meant by that...
@subnut for some reason the Chrome team completely rejected the update, but then I tried resubmitting the old version of GhostText and they accepted it (so it's not an issue with the type of extension). I assume they rejected it because they couldn't get it to work.
I'll try publishing the current version. Let's hope they don't reject it, because currently Firefox rejected the 19.x version (#177) and Chrome rejected this 20.x version (https://github.com/GhostText/GhostText/issues/172#issuecomment-755922046)
Version 21.1.1 has been approved by the Chrome store so you should receive the update soon! 👍
Firefox not yet
A brand-new version of GhostText is coming
The GhostText browser extension was rewritten from the ground up in #122 due to new restrictions introduced by browsers every so often.
It hasn't been published yet because it needs to be tested by you 💯
Issues?
Please include what you're testing:
Main changes