search

fregante / GhostText

👻 Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).
https://GhostText.fregante.com
MIT License
3.25k stars 116 forks source link

Keyboard shortcuts conflicts with GitHub command palette #218

Closed MrChocolatine closed 2 years ago

MrChocolatine commented 2 years ago

Hello @fregante.

Currently the keyboard shortcut to connect to GhostText is:

https://github.com/fregante/GhostText/blob/765dc7a6834c6a7b47eeb67daf14c0ac3cff3ea6/source/manifest.json#L47-L48

But it conflicts with GitHub's keyboard shortcut for its command palette:

https://github.blog/changelog/2021-10-27-command-palette-beta/

I am on Mac, using your extension, and I cannot invoke the command palette in "command mode". (unless I disable GhostText)

I would understand if you don't want to change it immediately, since the command palette is still in beta.

Thanks.

fregante commented 2 years ago

The shortcuts can be customized: https://ghosttext.fregante.com/#keyboard-shortcuts

Every shortcut has a conflict somewhere 😅

fregante commented 2 years ago

Plus I see no conflict, the shortcut is not the same. In this video you can see:

  1. cmd+k brings up the palette
  2. cmd+shift+k activates GT
  3. cmd+r to reload
  4. cmd+shift+k activates GT (no conflict with GitHub)

https://user-images.githubusercontent.com/1402241/139715459-02b86745-2840-4a20-9dea-b111962e9a54.mov

MrChocolatine commented 2 years ago

The shortcuts can be customized: https://ghosttext.fregante.com/#keyboard-shortcuts

Dang... And I know the page chrome://extensions/shortcuts actually, I just barely never use it. Thanks for the reminder and sorry for the useless issue.

Plus I see no conflict, the shortcut is not the same. In this video you can see:

There is a conflict yes.

The command palette can be opened in 2 modes, cmd + K and cmd + shift + K.

The extension GhostText was disabled when recording.

https://user-images.githubusercontent.com/47531779/139716856-cc81cb17-cdde-45d0-8417-ab8edcbf89ef.mov

fregante commented 2 years ago

Yes indeed that's why I resolved my comment 😉

I'm glad you're not using Safari though, because there's no solution there yet :(

MrChocolatine commented 2 years ago

A custom shortcut via chrome://extensions/shortcuts did the trick, obviously :v: .

Yes indeed that's why I resolved my comment 😉

I thought it was GitHub Refined that automatically collapsed the comment é_è .

jtran commented 2 years ago

I understand that GhostText cannot avoid collisions with everything, but GitHub isn't a tiny site in the long tail. I started using GhostText specifically so that I could write long GitHub comments using my editor of choice. I suspect that a large number of GhostText users are also GitHub users, and they're going to run into this.

Basically, I'm only asking, can you reconsider this issue?

fregante commented 2 years ago

@jtran what's the issue? What browser are you using?

jtran commented 2 years ago

I already customized the keyboard shortcut in Firefox before finding this GitHub issue. The problem is that I don't think GhostText users should need to do this. GhostText no longer works out of the box, and that's a poor user experience.

fregante commented 2 years ago

There is nothing I can do about this, every shortcut is used somewhere. Even if I change it here I'll break somewhere else, maybe even on GitHub itself in the future.

I can't even make it optional unfortunately, it's just how extensions work. The complaint should be made toward Chrome.