search

fregante / GhostText

👻 Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).
https://GhostText.fregante.com
MIT License
3.25k stars 116 forks source link

Activation shortcut broken on Firefox on 23.3.16 #276

Closed shouya closed 1 year ago

shouya commented 1 year ago

Setup

Browser: Firefox 110.0.1 on Linux Editor: Emacs

Description

After the extension upgraded to 23.3.16, the shortcut I set to activate GhostText no longer works. However, when clicking on the extension's button from the toolbar the everything still works fine as usual. I suspect it's related to https://github.com/fregante/GhostText/pull/269.

image

fregante commented 1 year ago

Thank you for the report. I had only tested it in Chrome. I think it's due to the new line 137.

Exploration/PR welcome

shouya commented 1 year ago

Indeed. I see the warning from the browser console and the tab is undefined.

image

fregante commented 1 year ago

It should be fixed in 23.3.24