No tab is open when using the Firefox plugin

fregante / GhostText

👻 Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).

https://GhostText.fregante.com

MIT License

3.28k stars 117 forks source link

No tab is open when using the Firefox plugin #86

Closed gwenzek closed 7 years ago

gwenzek commented 7 years ago

I'm using Ghost Text with both Chrome and Firefox.

It works fine with Chrome but not with Firefox. No tab is opened in ST, making it impossible to type text.

Here is the console output:

// Launch GhostText from Chrome
WebSocketServer id: 3
Setting on message handler
Setting on close handler
Start
Listening on: 40649
Bind view with id: 50
Setting on message handler
// Launch GhostText from Firefox
WebSocketServer id: 4
Setting on message handler
Setting on close handler
Start
Listening on: 38185

As you can see for some reason ST starts listening GhostText but doesn't open a view.

fregante commented 7 years ago

Are you using what's on the addons.mozilla.org website or the version on this repo? The AMO version is deprecated, try this repo's

gwenzek commented 7 years ago

I'm using the link from the README Where is this repo's version ?

I also tried to follow the second README without success (nothing happening on both side)

fregante commented 7 years ago

That's the right version.

After following the instructions:

Does the extension appear in the list?
Does the button appear in Firefox's UI?
If it does, try clicking it while on this page

gwenzek commented 7 years ago

Thanks for your indication I managed to install it. The thing which is confusing is that the version on the addons.mozilla.org is not working. Can't someone release a more recent version ? Anyway it should be mentionned in the main README.

I followed the instruction inside the /browser/README.

The npm run build failed because I was on Ubuntu with the wrong version of node-js installed. This is a known issue described here.

After sudo apt-get install nodejs-legacy, I was able to build the plugin and it's working !

Note that even if the npm run build fail, you can still add the plugin to Firefox and it will show the button but it will be non-working.

fregante commented 7 years ago

Is it working or non-working? What happens when you click the button while you're on this page?

gwenzek commented 7 years ago

Sorry if I haven't been clear but it's working normally now. Clicking on the button ask to select a text area and then a tab is open in ST.

I detailed the install instructions and problem I faced on case someone has the same problem than me.

fregante commented 7 years ago

Cool, thanks for the report! Unfortunately I can't update the plugin on addons.mozilla

fregante commented 7 years ago

The new GhostText Firefox extension has been published https://addons.mozilla.org/en-US/firefox/addon/ghosttext/ :)

gwenzek commented 7 years ago

Thanks for the update ! The official Firefox plugin is working smoothly now :-)

fregante commented 7 years ago

Good to hear :)

Please leave a review on the new plugin so people know it's the right one