search

fregante / GhostText

👻 Use your text editor to write in your browser. Everything you type in the editor will be instantly updated in the browser (and vice versa).
https://GhostText.fregante.com
MIT License
3.28k stars 117 forks source link

Changes requested by Mozilla #94

Closed fregante closed 7 years ago

fregante commented 7 years ago

Your add-on, GhostText 1.2.4, has been reviewed and did not meet the criteria for being hosted in our gallery. This version didn't pass review because of the following problems:

  • [x] Please add an add-on description that explains what the add-on requires (some external server?), what it does and how it can be used.
  • [x] Please remove unnecessary files such as the .ts files, .DS_Store and __MACOSX.
  • [x] If you are interested in trimming code size too, remove jQuery and replace the $.get call (scripts/lib.js, line 136) with the XMLHttpRequest or fetch APIs.
  • [x] There is no guarantee that the parameter to checkProtocolVersion in scripts/lib.js is a number. Please make sure that it is a number, e.g. by using parseInt, parseFloat, Number, or any other method to convert an input to a number. This ensures that the notifyUser method cannot be used by external (local) servers for injecting HTML.
  • [ ] GhostTextContent.port.onMessage.addListener in scripts/content.js calls GhostTextContent.currentInputArea.setText, based on data from the localhost response. It is not obvious that the text can be used as HTML: some of the setText methods in scripts/input-area.js treat the input as text, whereas others treat it as HTML. If the input is supposed to be text only, please replace all occurrences of innerHTML in scripts/input-map.js with textContent (or innerText).
fregante commented 7 years ago

Changes applied. New version submitted

fregante commented 7 years ago

https://addons.mozilla.org/en-US/firefox/addon/ghosttext/ 🎉