search

fregante / iphone-inline-video

📱 Make videos playable inline on the iPhone (prevents automatic fullscreen)
https://npm.im/iphone-inline-video
MIT License
2.05k stars 300 forks source link

#33 make events be abled to get in full screen mode #123

Closed saury closed 7 years ago

saury commented 7 years ago

Hi, I've made some simple changes to the source code so that the missing events could be able to get when entering the full screen mode and no need to proxy these events as workarounds to get if somebody need them. Event timeupdate may not useful in most cases, but ended is quite common in order to exit the full screen mode automatically.

fregante commented 7 years ago

variables is global, this won't work if there is more than one video. Also IIV needs to be avoid pushing its own ended event.

Thank you for the PR, it showed me how easy it was to fix this! I was imagining it much more difficult. I fixed this in 0444341d5ef5526a6d7649858e3360fd1a7d1646, v2.2.0